Upgrade Storybook to v8 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran: $ npx storybook@latest upgrade And fixed a few remaining issues following: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-7x-to-800.
tjmw
force-pushed
the
tw/upgrade-storybook-v8
branch
from
4dc9762
to
cefe1b7
Compare
I'm seeing an error when attempting to use the Grid add on: "render: `key` is not a prop. Trying to access it will result in `undefined` being returned. If you need to access the same value within the child component, you should pass it as a different prop"
…cker I don't fully understand why.
tjmw
force-pushed
the
tw/upgrade-storybook-v8
branch
from
dc2d0c4
to
1b1b276
Compare
Will this fix this error, which I don't see locally but do see in code: "Storybook preview hooks can only be called inside decorators and story functions."
tjmw
force-pushed
the
tw/upgrade-storybook-v8
branch
from
b1ee5d7
to
0f8b3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrade Storybook to v8. This major version bump removes the other path which was bringing in the vulnerable
ippackage (the first use was removed in #500).I ran:
$ npx storybook@latest upgradeAnd fixed a few remaining issues following:
https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#from-version-7x-to-800.
Note: the base is #500.How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility