Braze Banner accessibility fixes #400
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaliedaRik
commented
Feb 22, 2023
| @@ -51,6 +51,20 @@ export const styles = { | |||
| } | |||
| `, | |||
|
|
|||
| topBar: css` | |||
There was a problem hiding this comment.
This file can be deleted once the other two banners are moved over to the new components
Base automatically changed from
rjr-create-newsletter-banner-component
to
rjr-refactor-common-newsletter-components-and-functionality
March 10, 2023 13:07
Base automatically changed from
rjr-refactor-common-newsletter-components-and-functionality
to
rjr-remove-information-icon-from-banners
March 10, 2023 13:13
Base automatically changed from
rjr-remove-information-icon-from-banners
to
rjr-refactor-storybook-stories
March 10, 2023 13:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Hackday project to make Braze banners properly accessible
Refactors AppBanner by:
Note that this PR builds on #398