Skip to content

Commit

Permalink
Merge pull request #121 from guardian/tw-dont-use-window-guardian-aut…
Browse files Browse the repository at this point in the history
…omat

Don't rely on dependencies on the window object
  • Loading branch information
rhystmills authored Apr 6, 2021
2 parents 5b7778a + e8056d7 commit 238e289
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,15 @@
},
"peerDependencies": {
"@emotion/core": "10.0.x",
"emotion-theming": "^10.0.19",
"@guardian/libs": "^1.7.0",
"preact-x": "npm:[email protected]",
"react": "16.13.x"
},
"dependencies": {
"@guardian/src-button": "2.7.1",
"@guardian/src-foundations": "2.7.1",
"@guardian/src-grid": "2.7.1",
"@guardian/src-icons": "2.7.1",
"emotion-theming": "^10.0.19"
"@guardian/src-icons": "2.7.1"
},
"np": {
"branch": "main"
Expand Down
3 changes: 0 additions & 3 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import commonjs from '@rollup/plugin-commonjs';
import replace from '@rollup/plugin-replace';
import { terser } from 'rollup-plugin-terser';
import peerDepsExternal from 'rollup-plugin-peer-deps-external';
import externalGlobals from 'rollup-plugin-external-globals';
import pkg from './package.json';
import logicPkg from './logic/package.json';
import visualizer from 'rollup-plugin-visualizer';
Expand All @@ -20,7 +19,6 @@ const globals = {
};

const commonConfig = {
external: (id) => Object.keys(globals).some((key) => id == key),
plugins: [
peerDepsExternal(),
resolve({ extensions: extensions }),
Expand All @@ -32,7 +30,6 @@ const commonConfig = {
}),
terser(),
filesize(),
externalGlobals(globals),
// Note, visualizer is useful for *relative* sizes, but reports
// pre-minification.
visualizer({ gzipSize: true }),
Expand Down

0 comments on commit 238e289

Please sign in to comment.