Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update content-api-models to 26.0.0 #100

Merged
merged 3 commits into from
Jan 14, 2025
Merged

update content-api-models to 26.0.0 #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
341c11e
update content-api-models to 26.0.0
marjisound Jan 7, 2025
6e4f988
install sbt before renning it in release workflow
marjisound Jan 8, 2025
e445003
add setup-sbt action instead of manually install sbt
marjisound Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
with:
node-version-file: .nvmrc
registry-url: https://registry.npmjs.org
- uses: sbt/[email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner latest version doesn't seem to have sbt anymore. We have to install sbt ourselves. This is happening in other repos too. e.g. https://github.com/guardian/content-api-scala-client/blob/7fbcead38ad66108c50448f53bcea00b2a309474/.github/workflows/ci.yml#L23

- name: Release Typescript to NPM
run: |
sbt "project tsApiModels" "releaseNpm ${{ needs.scala-maven-release.outputs.RELEASE_VERSION }}"
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import sbtversionpolicy.withsbtrelease.ReleaseVersion
val contentEntityVersion = "3.0.3"
val contentAtomVersion = "4.0.4"
val storyPackageVersion = "2.2.0"
val contentApiModelsVersion = "25.1.1"
val contentApiModelsVersion = "26.0.0"

val scroogeDependencies = Seq(
"content-api-models",
Expand Down
Loading