forked from rubyist/guard-rake
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 2 #4
Open
edusantana
wants to merge
51
commits into
guard:master
Choose a base branch
from
edusantana:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Patch 2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubyist#1 This is to avoid conflict with Guard::Rake class definition. I don't know the purpose of this file, but from other guard plugins I take that plugin name + "Version" is the convention.
Fix for issue #1
Adds 'run_on_all' option
Added reenable for all tasks, changed execute to invoke.
Rake has a convention of automatically loading tasks defined in any *.rake files under the ./rakelib directory. This change uses Rake's internal mechanism for loading a Rakefile which respects this convention.
Use Rake methods to initialize and load Rakefile
Ruby 1.8 compatibility
See Yehuda's article at: http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/ for more info.
This suppresses a deprecation notice given when using guard-rake with Guard 1.1 and higher.
Avoid deprecation messages with Guard 1.1.x
Fix missing require for guard/version
run_on_start option is no longer dependent on the run_on_all option.
run_on_start option is no longer dependent on the run_on_all option.
If a rake task failed or raised an exception then Guard would automatically disable guard-rake meaning that changes for rake tasks would no longer be fired. Rather than raise the exception we `throw :task_has_failed` to match the guard api and log the error. Based on joergschiller's branch of guard-rake.
Catch exceptions during rake tasks so guard doesn't disable guard-rake.
…task Update README to include better task_args and changed path examples
add notification
Fixed a markup issue; now it's properly formatted! Yay for easy contributions :-)
Fix markdown on Readme.md
Run on modifications instead of changes.
Add license to gemspec.
this is my way to provide this feature rubyist#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.