Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Redmine 6 #338

Merged
merged 14 commits into from
Nov 18, 2024
Merged

Support Redmine 6 #338

merged 14 commits into from
Nov 18, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented Nov 16, 2024

Changes proposed in this pull request:

  • Supports Redmine 6
  • Uses SVG icon for admin menu
  • Updates dependencies
  • Clean up of some hooks

Not sure if these changes still work with v5. Needs to be checked.

@dkastl dkastl requested a review from sanak November 16, 2024 14:39
@sanak sanak mentioned this pull request Nov 17, 2024
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkastl Thanks a lot!
I confirmed that all tests passed in this branch.

Supporting Redmine 5 seems to be possible with slight change, so I created another PR (#339) to this PR branch.

init.rb Show resolved Hide resolved
@dkastl
Copy link
Member Author

dkastl commented Nov 17, 2024

I forgot that I also need to check for API updates/changes.

init.rb Show resolved Hide resolved
init.rb Show resolved Hide resolved
@dkastl
Copy link
Member Author

dkastl commented Nov 18, 2024

@sanak , I updated the API templates and reviewed the README.
If you are fine with the changes so far, then I will merge into next.

@dkastl dkastl requested a review from sanak November 18, 2024 08:09
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanak , I updated the API templates and reviewed the README. If you are fine with the changes so far, then I will merge into next.

Thanks!
LGTM about the diffs (9cdc7b5).

@dkastl dkastl merged commit 4a1a4a8 into next Nov 18, 2024
10 checks passed
@dkastl dkastl deleted the support-redmine-6 branch November 18, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants