Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved editor control #311

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Improved editor control #311

merged 6 commits into from
Jun 5, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented Jun 4, 2024

Fixes #310 .

Changes proposed in this pull request:

  • Adds a new control button Edit
  • Enables vertex and line snapping
  • Inform the user about ALT+<click> shortcut to delete a vertex.
  • Provides a delete button through tooltip
  • Draws existing features temporarily light gray when adding a new feature

@dkastl dkastl changed the base branch from main to next June 4, 2024 17:00
@dkastl dkastl requested review from sanak and smellman June 4, 2024 17:06
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkastl Thanks for improvement!

About tooltip message, I added comment on the line.

Also, if the followings are possible, it would be nice, I think.

  • Disable Edit button when:
    • There is no geometry on the map
    • Geometry type is point (point seems to needs creating new one at this moment)

config/locales/en.yml Show resolved Hide resolved
@dkastl dkastl self-assigned this Jun 5, 2024
@dkastl dkastl added the enhancement New feature or request label Jun 5, 2024
@dkastl dkastl merged commit fee38bf into next Jun 5, 2024
10 checks passed
@dkastl dkastl deleted the dkastl/issue310 branch June 5, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an easy way to delete feature vertices
2 participants