Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplements Geocoder/Location Search #285

Merged
merged 16 commits into from
Jun 2, 2024
Merged

Reimplements Geocoder/Location Search #285

merged 16 commits into from
Jun 2, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented May 29, 2024 •
edited
Loading

Fixes #98 and #198 .

Changes proposed in this pull request:

  • Drops previous Geocoder implementation
  • Uses and extends ol.control.Search
  • Improved plugin settings
  • Support for various location search services

Adds support for

  • Nominatim
  • Photon
  • Google Geocoder
  • Custom Search

dkastl added 13 commits May 29, 2024 18:31
@dkastl
Implements SearchGTT basic class
1872a8e 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Removes legacy Geocoder control
021d827 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Extends plugin setting
361c743 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Passes Geocoder plugin settings
f3cbe3d 
enable/disable geocoder control

Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Implements Search Factory
cafe15f 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Pass and merge options
775b28b 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Select event listener zooms to result item
e5c2cea 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Initial version of Google Geocoding
d8ecc5d 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Adds comments
61925bd 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Minor adjustments
2eb9a19 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Fixes reverse search button
83d76d6 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Cleanup config
6941357 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl
Supports more parameters
5ba9f26 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl dkastl marked this pull request as ready for review May 31, 2024 09:49
@dkastl dkastl requested a review from sanak May 31, 2024 09:49
@dkastl
completes docs
98ef713 
Signed-off-by: Daniel Kastl <[email protected]>
@dkastl dkastl requested a review from smellman May 31, 2024 10:06
@dkastl dkastl mentioned this pull request May 31, 2024
Closed
@dkastl dkastl added this to the v5.1.0 milestone May 31, 2024
sanak
sanak approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks a lot!

@dkastl dkastl merged commit 62fd609 into next Jun 2, 2024
10 checks passed
@dkastl dkastl deleted the dkastl/issue98 branch June 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanak sanak sanak approved these changes

@smellman smellman Awaiting requested review from smellman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dkastl @sanak