Skip to content

Commit

Permalink
Add @kbn/shared-ux-router to shared bundle (elastic#204786)
Browse files Browse the repository at this point in the history
## Summary

Part of elastic#204761 . This package
is used by every app and I thought it is worth adding it to the shared
bundle. Especially since it is already part of Bazel.
  • Loading branch information
Dosant authored Dec 30, 2024
1 parent 140c2e0 commit b64ff10
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/kbn-ui-shared-deps-src/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ webpack_cli(
"//packages/react/kibana_context/root",
"//packages/react/kibana_context/render",
"//packages/react/kibana_context/theme",
"//packages/shared-ux/router/impl:shared-ux-router",
],
output_dir = True,
args = [
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-ui-shared-deps-src/src/definitions.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ const externals = {
'@kbn/react-kibana-context-root': '__kbnSharedDeps__.KbnReactKibanaContextRoot',
'@kbn/react-kibana-context-render': '__kbnSharedDeps__.KbnReactKibanaContextRender',
'@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme',
'@kbn/shared-ux-router': '__kbnSharedDeps__.KbnSharedUxRouter',
};

module.exports = { distDir, jsFilename, cssDistFilename, externals };
1 change: 1 addition & 0 deletions packages/kbn-ui-shared-deps-src/src/entry.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,4 @@ export const KbnReactKibanaContextCommon = require('@kbn/react-kibana-context-co
export const KbnReactKibanaContextRoot = require('@kbn/react-kibana-context-root');
export const KbnReactKibanaContextRender = require('@kbn/react-kibana-context-render');
export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme');
export const KbnSharedUxRouter = require('@kbn/shared-ux-router');

0 comments on commit b64ff10

Please sign in to comment.