Skip to content

Commit

Permalink
Small UI fixes for new Space creation/settings page (elastic#197303)
Browse files Browse the repository at this point in the history
## Summary
[According to this
PRD](https://docs.google.com/document/d/1HC_YjDtIzRvweU-oy6K2DevKfSvwfdHHZbjLFA43xls/edit#heading=h.jf3bwdwv0goe).

* Solution selection inside space settings is now full width (point 7)
* "Solution view" in features visibility section is not bold anymore
(point 8)
* Slightly tweaked placement for header and badges (point 14)

![CleanShot 2024-10-22 at 18 47
34@2x](https://github.com/user-attachments/assets/831772e4-e342-4999-baa4-79ec7341ffa9)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
  • Loading branch information
3 people authored Oct 24, 2024
1 parent 7dd66b3 commit aaa9604
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 16 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,10 @@ export const EnabledFeatures: FunctionComponent<Props> = (props) => {
defaultMessage="Choose the features to display in the navigation menu for users of this space. If you want to focus on a single solution, you can simplify the navigation even more by selecting a {solutionView}."
values={{
solutionView: (
<strong>
<FormattedMessage
id="xpack.spaces.management.enabledSpaceFeatures.chooseFeaturesToDisplaySolutionViewText"
defaultMessage="Solution view"
/>
</strong>
<FormattedMessage
id="xpack.spaces.management.enabledSpaceFeatures.chooseFeaturesToDisplaySolutionViewText"
defaultMessage="Solution view"
/>
),
}}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export const SolutionView: FunctionComponent<Props> = ({

return (
<SectionPanel title={sectionTitle} dataTestSubj="navigationPanel">
<EuiFlexGroup alignItems="flexStart">
<EuiFlexGroup alignItems="baseline">
<EuiFlexItem>
<EuiTitle size="xs">
<EuiFlexGroup gutterSize="s">
Expand Down Expand Up @@ -163,6 +163,7 @@ export const SolutionView: FunctionComponent<Props> = ({
onChange={(solution) => {
onChange({ ...space, solution });
}}
fullWidth={true}
placeholder={i18n.translate(
'xpack.spaces.management.navigation.solutionViewDefaultValue',
{ defaultMessage: 'Select solution view' }
Expand All @@ -180,7 +181,7 @@ export const SolutionView: FunctionComponent<Props> = ({
/>
</EuiText>

<EuiSpacer />
<EuiSpacer size="m" />
<EuiCallOut
color="primary"
size="s"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ export const EditSpace: FC<PageProps> = ({
>
<EuiFlexItem grow={true} css={{ flexBasis: '100%', width: '100%' }}>
<EuiFlexGroup>
<EuiFlexItem grow={false}>
<EuiFlexItem grow={false} css={{ marginTop: '4px' }}>
<HeaderAvatar />
</EuiFlexItem>
<EuiFlexItem grow={true}>
Expand Down Expand Up @@ -246,7 +246,7 @@ export const EditSpace: FC<PageProps> = ({
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiFlexItem grow={false} css={{ marginTop: '4px' }}>
<div>
{shouldShowSolutionBadge ? (
<SpaceSolutionBadge
Expand Down

0 comments on commit aaa9604

Please sign in to comment.