Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: replace dial with newclient #7920

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

janardhanvissa
Copy link
Contributor

@janardhanvissa janardhanvissa commented Dec 11, 2024

Partially address: #7049

RELEASE NOTES: None

@arjan-bal
Copy link
Contributor

The tests are failing, please fix the failures. In the future, please ensure that tests pass locally before raising a PR.

go test ./... -count=1 -failfast                                                         

@arjan-bal arjan-bal self-requested a review December 11, 2024 05:26
@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Dec 11, 2024
@arjan-bal arjan-bal added this to the 1.70 Release milestone Dec 11, 2024
@janardhanvissa
Copy link
Contributor Author

The tests are failing, please fix the failures. In the future, please ensure that tests pass locally before raising a PR.

go test ./... -count=1 -failfast                                                         

I have tested locally before pushing the code, nothing is failing. Let me re-trigger the PR.

@janardhanvissa janardhanvissa force-pushed the newclient-insteadof-dial branch from c5b8178 to 76915bd Compare December 11, 2024 10:20
test/creds_test.go Outdated Show resolved Hide resolved
test/creds_test.go Outdated Show resolved Hide resolved
resolver_balancer_ext_test.go Outdated Show resolved Hide resolved
test/creds_test.go Outdated Show resolved Hide resolved
test/creds_test.go Outdated Show resolved Hide resolved
@arjan-bal
Copy link
Contributor

arjan-bal commented Dec 13, 2024

The test failure for the new pickfirst policy seem to be because the DNS resolver is resolving localhost to both the IPv4 and IPv6 addresses, while the server listens only on the IPv4 address. Can you change the following line to la := "[::]:0" and see if the test passes?

la := "localhost:0"

This should make the server listen on both the IPv4 and IPv6 localhost addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants