-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc: fix receiving empty messages when compression is enabled and maxReceiveMessageSize is maxInt64 #7753 #7914
Closed
vinothkumarr227
wants to merge
18
commits into
grpc:master
from
vinothkumarr227:4552-empty-response-on-enable-decompression
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
requested review from
purnesh42H
and removed request for
purnesh42H
December 10, 2024 09:55
@vinothkumarr227 can you please squash the commits before we start reviewing the PR? |
Sure, I will do it |
vinothkumarr227
force-pushed
the
4552-empty-response-on-enable-decompression
branch
from
December 10, 2024 11:10
ae27ab0
to
a3b77c9
Compare
I worked on Vivek's branch for the changes related to pull request #7914, but encountered permission and merge conflicts. I have now created a new branch from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4552
RELEASE NOTES:
grpc: fix receiving empty messages when compression is enabled and maxReceiveMessageSize is maxInt64