#5888 cleanup old env vars #7911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of issue grpc#5888 removes the ability to toggle ALPN enforcment as the default is true and there is a development policy in place that when env values become true by default, the toggle behavior should be removed
now that ALPN is always enforced, the table driven tests that support this can be removed. most of the changes are whitespace, however an assertion has been modified so that the tests will fail if an expected error is not returned
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7911 +/- ##
==========================================
+ Coverage 82.04% 82.07% +0.03%
==========================================
Files 377 377
Lines 38180 38175 -5
==========================================
+ Hits 31326 31334 +8
+ Misses 5551 5542 -9
+ Partials 1303 1299 -4
|
|
Hi @pnikonowicz, thanks for the PR. We can't remove the environment variable for ALPN enforcement as some users need a way to disable this for backward compatibility, see #7769 I've mentioned the same in #5888. Closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleans up the ALPN enabled env var via 2 commits:
this does not address all of #5888 and therefore should remain open