Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health, grpc: Deliver health service updates through the health listener #7900

Merged
merged 5 commits into from
Dec 12, 2024

Address review

5cf90ee
Select commit
Loading
Failed to load commit list.
Merged

health, grpc: Deliver health service updates through the health listener #7900

Address review
5cf90ee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

82.04% (-0.10%) compared to 317271b

View this Pull Request on Codecov

82.04% (-0.10%) compared to 317271b

Details

Codecov Report

Attention: Patch coverage is 89.02439% with 9 lines in your changes missing coverage. Please review.

Project coverage is 82.04%. Comparing base (317271b) to head (5cf90ee).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
health/producer.go 86.66% 4 Missing and 2 partials ⚠️
balancer_wrapper.go 91.89% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7900      +/-   ##
==========================================
- Coverage   82.13%   82.04%   -0.10%     
==========================================
  Files         377      378       +1     
  Lines       38179    38258      +79     
==========================================
+ Hits        31360    31389      +29     
- Misses       5525     5561      +36     
- Partials     1294     1308      +14     
Files with missing lines Coverage Δ
balancer_wrapper.go 85.27% <91.89%> (-0.83%) ⬇️
health/producer.go 86.66% <86.66%> (ø)

... and 19 files with indirect coverage changes