grpc: server should send RST_STREAM when deadline is exceeded

[misvivek]

Fixes: #2886

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.95%. Comparing base (634497b) to head (86a4997).
Report is 7 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7892      +/-   ##
==========================================
- Coverage   82.04%   81.95%   -0.09%     
==========================================
  Files         377      377              
  Lines       38117    38183      +66     
==========================================
+ Hits        31272    31294      +22     
- Misses       5548     5585      +37     
- Partials     1297     1304       +7     

Files with missing lines	Coverage Δ
internal/transport/http2_server.go	90.99% <100.00%> (+0.30%)	⬆️

... and 22 files with indirect coverage changes

[purnesh42H]

you have to wait on channel as well otherwise you are not verifying the if your function was triggered

select {
case <-ch:  // Signal received, continue with the test
case <-s.ctx.Done():
case <-time.After(5 * time.Second):
	t.Errorf("timeout waiting for ctx.Done")
	return
}

[misvivek]

done

[purnesh42H]

@misvivek i just saw you are doing this inside goroutine which won't affect the execution of test whether pass or fail.

You need to move both no op function setting and channel waiting code outside of go routine and check at the end when go runStream(s) is done, perhaps at the end after checking the trailers. So I would structure it like this

// rst flag setting to verify the noop function: signalDeadlineExceeded
ch := make(chan struct{}, 1)
origSignalDeadlineExceeded := signalDeadlineExceeded
signalDeadlineExceeded = func() {
ch <- struct{}{}
}
defer func() {
signalDeadlineExceeded = origSignalDeadlineExceeded
}()

runStream := func(s *ServerStream) {....}

...
...

checkHeaderAndTrailer(t, rw, wantHeader, wantTrailer)
select {
case <-ch: // Signal received, continue with the test
case <-time.After(5 * time.Second):
t.Errorf("timeout waiting for ctx.Done")
return
}

[purnesh42H]

And i think the test will fail then because you haven't yet fixed the bug.

[purnesh42H]

@misvivek you need to write the test as I mentioned above and then verify if the test is failing. If it is, then we have to fix the bug first.

[purnesh42H]

Need to fix the bug as well along with test