Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stats/opentelemetry: introduce tracing propagator and carrier #7677
stats/opentelemetry: introduce tracing propagator and carrier #7677
Changes from 30 commits
d0a0b51
edf1604
5709a43
c97cbb5
4144464
4f49b4f
96abe67
4839c45
ce6cbd4
59b87e7
26ee1b0
c5afe54
309dbf6
760330c
38cde19
309386a
23c9a58
3c8389b
062e769
ee2869c
6756247
de4ba6c
04ee6cb
86d29bb
21a13be
c180834
2540965
4f77441
d708a8b
a3c8693
268b0a3
5c7b69a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 70 in stats/opentelemetry/grpc_trace_bin_propagator.go
Codecov / codecov/patch
stats/opentelemetry/grpc_trace_bin_propagator.go#L69-L70
Check warning on line 80 in stats/opentelemetry/grpc_trace_bin_propagator.go
Codecov / codecov/patch
stats/opentelemetry/grpc_trace_bin_propagator.go#L79-L80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When your test cases diverge in behavior so much, it really just feels like two different tests instead of one table driven test. Optionally rewrite that way to make it easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrote separate tests for valid and invalid span context injection