#6 Receive Achievements #34
Conversation
| ``` | ||
| **Receive Achievements** | ||
|
|
||
| You'll need an admin token to make this example work |
There was a problem hiding this comment.
Use long form of will. Simple language is important in documentation like this, because most people reading the documentation will not be natives and only have limited language proficiency.
| } | ||
|
|
||
| for _, achievement := range achievements { | ||
| // Do something with the achievement |
There was a problem hiding this comment.
Please add an example like printing the title of the achievement.
for _, achievement := range achievements {
fmt.Println(achievement.Title)
}
| Email string `json:"email"` | ||
| } | ||
|
|
||
| func (client *Client) GetAchivements() ([]Achievement, error) { |
There was a problem hiding this comment.
| } | ||
|
|
||
| func Test_gettingAchievements(t *testing.T) { | ||
| server := httpMock("/api/v1/achievements", http.StatusOK, `{ |
There was a problem hiding this comment.
No need for HTTP mocking here. Use a mock of the bonusly Client.
See: https://github.com/groundfoghub/bonusly-sdk-go/blob/main/user_test.go#L170-L181
| @@ -0,0 +1,70 @@ | |||
| package bonusly | |||
There was a problem hiding this comment.
Try to use table tests in Go.
| Email string `json:"email"` | ||
| } | ||
|
|
||
| func (client *Client) GetAchivements() ([]Achievement, error) { |
There was a problem hiding this comment.
Create a type GetAchievementsOutput and return a pointer to it.
| bodyMessage, readErr := readBody(resp) | ||
|
|
||
| if readErr != nil { | ||
| return make([]Achievement, 0), readErr |
There was a problem hiding this comment.
Return nil instead of empty array.
| resp, requestErr := client.Do(req) | ||
|
|
||
| if requestErr != nil { | ||
| return make([]Achievement, 0), requestErr |
There was a problem hiding this comment.
Return nil instead of empty array.
| jsonParsingErr := json.Unmarshal([]byte(bodyMessage), &archivements) | ||
|
|
||
| if jsonParsingErr != nil { | ||
| return make([]Achievement, 0), jsonParsingErr |
There was a problem hiding this comment.
Return nil instead of empty array.
| Email string `json:"email"` | ||
| } | ||
|
|
||
| func (client *Client) GetAchivements() ([]Achievement, error) { |
There was a problem hiding this comment.
use c as receiver name instead of client for consistency.
Changes
#6 Listing Recent Achievements