Merge pull request #39 from goatapp/rescue-exception

Rescue from Exception, not just StandardError

lib/ar_after_transaction.rb

@@ -48,7 +48,7 @@ def transaction_with_after(**args)
       clean = false
       raise
     end
-  rescue StandardError
+  rescue Exception
     clean = false
     raise
   ensure

spec/ar_after_transaction_spec.rb

@@ -34,6 +34,10 @@ def oops
   def raise_rollback
     raise ActiveRecord::Rollback
   end
+
+  def sigterm
+    raise SignalException.new('TERM')
+  end
 end
 
 describe ARAfterTransaction do
@@ -54,12 +58,18 @@ def raise_rollback
     expect(User.test_stack).to eq [:normal, :after]
   end
 
-  it 'does not execute when transaction was rolled back' do
+  it 'does not execute when transaction was rolled back by a StandardError' do
     User.test_callbacks = [:do_after, :do_normal, :oops]
     expect(-> { User.create! }).to raise_error(AnExpectedError)
     expect(User.test_stack).to eq [:normal]
   end
 
+  it 'does not execute when transaction was rolled back by an Exception' do
+    User.test_callbacks = [:do_after, :do_normal, :sigterm]
+    expect(-> { User.create! }).to raise_error(SignalException)
+    expect(User.test_stack).to eq [:normal]
+  end
+
   it 'does not execute when transaction gets rolled back by ActiveRecord::Rollback '\
      'raised in an after_create callback' do
     User.test_callbacks = [:do_after, :do_normal, :raise_rollback]