Add support for nested attributes, bug fixes and refactoring #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
subham-soni
commented
Sep 16, 2024
•
subham-soni
commented
- SchemaValidationUtils - Add support for nested attributes. Refactor to validate schema and individual attributes separately.
- Simplified NamespaceDataSource to use a supplier instead of hierarchy for static and dynamic source
- LeiaBundle: Fixed duplicate instantiation of schema repository
- TimeBasedDataProvider:
- Fixed the initial delay of executor to prevent multiple invocation of update on startup
- Refactor time based data provider to throw an exception if refresh fails on start
- Schema Validator: Removed instance creation of schema class. It's not required for static validations.
subham-soni
force-pushed
the
fixes_and_optimizations
branch
from
4d21134 to
985be2e
Compare
|
@subham-soni : Some description on what is getting fixed, pls. Can't merge MRs with small fixes. |
subham-soni
force-pushed
the
fixes_and_optimizations
branch
from
985be2e to
ca32b81
Compare
koushikr
reviewed
Sep 18, 2024
leia-schema-validator/src/main/java/com/grookage/leia/validator/StaticSchemaValidator.java
Outdated
Show resolved
Hide resolved
...-schema-validator/src/main/java/com/grookage/leia/validator/utils/SchemaValidationUtils.java
Outdated
Show resolved
Hide resolved
...-schema-validator/src/main/java/com/grookage/leia/validator/utils/SchemaValidationUtils.java
Outdated
Show resolved
Hide resolved
leia-client/src/main/java/com/grookage/leia/client/refresher/LeiaClientRefresher.java
Show resolved
Hide resolved
leia-refresher/src/main/java/com/grookage/leia/provider/TimeBasedDataProvider.java
Outdated
Show resolved
Hide resolved
...-schema-validator/src/main/java/com/grookage/leia/validator/utils/SchemaValidationUtils.java
Outdated
Show resolved
Hide resolved
...-schema-validator/src/main/java/com/grookage/leia/validator/utils/SchemaValidationUtils.java
Outdated
Show resolved
Hide resolved
|
@subham-soni : Also change the title of the MR to reflect the changes. |
subham-soni
changed the title
subham-soni
changed the title
koushikr
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.