Skip to content

Commit

Permalink
adds contributors.md, constraints on SchemaKey and schemakey delimite…
Browse files Browse the repository at this point in the history
…r change
  • Loading branch information
Gunda Abhishek committed Dec 4, 2024
1 parent 545c3cc commit 4b79616
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 4 deletions.
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@ All notable changes to this project will be documented in this file.

## [0.0.1-RC8]

- LeiaElasticBundle: Fixes the override for adding ElasticHealthCheck
- Removed the unused `LeiaCompiledPath` class
- SchemaDetails:
- Moved the nested `SchemaKey` attributes to the class level
- made the getReferenceId() uniform with `SchemaKey` implementation
- FieldUtils: Excluding non-serializable fields(static, transient, @JsonIgnore) for building the schema attributes
- SchemaResource: Bug fix in SchemaValidation resource
- Removed the unused `LeiaCompiledPath` class

## [0.0.1-RC7]

Expand Down
6 changes: 6 additions & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
### Contributors

* [Koushik R](https://github.com/koushikr)
* [Abhishek](https://github.com/abhigun)
* [Subham](https://github.com/nullsoni)

Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import lombok.Data;
import lombok.NoArgsConstructor;

import javax.validation.Valid;
import javax.validation.constraints.NotNull;

@Data
Expand All @@ -16,6 +17,7 @@
@NoArgsConstructor
@JsonIgnoreProperties(ignoreUnknown = true)
public class ValidateSchemaRequest {
@Valid
@NotNull
private SchemaKey schemaKey;
@NotNull
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public boolean match(final SchemaKey thatKey) {

@JsonIgnore
public String getReferenceId() {
return Joiner.on(".").join(namespace, schemaName, version).toUpperCase(Locale.ROOT);
return Joiner.on(":").join(namespace, schemaName, version).toUpperCase(Locale.ROOT);
}

@JsonIgnore
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import lombok.Data;
import lombok.NoArgsConstructor;

import javax.validation.constraints.NotBlank;
import java.util.Locale;

@Builder
Expand All @@ -32,13 +33,16 @@
@NoArgsConstructor
@JsonIgnoreProperties(ignoreUnknown = true)
public class SchemaKey {
@NotBlank
private String namespace;
@NotBlank
private String schemaName;
@NotBlank
private String version;

@JsonIgnore
public String getReferenceId() {
return Joiner.on(".").join(namespace, schemaName, version).toUpperCase(Locale.ROOT);
return Joiner.on(":").join(namespace, schemaName, version).toUpperCase(Locale.ROOT);
}

@Override
Expand Down

0 comments on commit 4b79616

Please sign in to comment.