tmp

grongor · Aug 23, 2024 · 14c95fa · 14c95fa
1 parent cf501f1
commit 14c95fa
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 9 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -42,9 +42,9 @@ jobs:
                 with:
                     go-version: '^1.23'
             -   name: Install dependencies
-                run: sudo apt update && sudo apt install libsnmp-dev python3-pip snmp-mibs-downloader
+                run: sudo apt update && sudo apt install libsnmp-dev pipx snmp-mibs-downloader
             -   name: Install snmpsim
-                run: sudo pip3 install snmpsim
+                run: pipx install snmpsim
             -   name: Run tests
                 run: make test
 
@@ -57,9 +57,9 @@ jobs:
                 with:
                     go-version: '^1.23'
             -   name: Install dependencies
-                run: sudo apt update && sudo apt install python3-pip
+                run: sudo apt update && sudo apt install pipx
             -   name: Install snmpsim
-                run: sudo pip3 install snmpsim
+                run: pipx install snmpsim
             -   name: Run tests
                 run: GO_TEST_FLAGS=-tags=nonetsnmp make test
 
@@ -72,9 +72,9 @@ jobs:
                 with:
                     go-version: '^1.23'
             -   name: Install dependencies
-                run: sudo apt update && sudo apt install libsnmp-dev python3-pip snmp-mibs-downloader
+                run: sudo apt update && sudo apt install libsnmp-dev pipx snmp-mibs-downloader
             -   name: Install snmpsim
-                run: sudo pip3 install snmpsim
+                run: pipx install snmpsim
             -   name: Download go-acc
                 run: go install github.com/ory/go-acc@latest
             -   name: Generate Code Coverage
@@ -95,4 +95,4 @@ jobs:
             -   name: Install dependencies
                 run: sudo apt update && sudo apt install libsnmp-dev
             -   name: golangci-lint
-                uses: golangci/golangci-lint-action@v5
+                uses: golangci/golangci-lint-action@v6
diff --git a/.golangci.yml b/.golangci.yml
@@ -56,7 +56,15 @@ linters-settings:
             - fieldalignment # @todo fix later
 
     gosec:
-        excludes: [G501, G502, G503, G504, G505] # ignore imports, usages are still reported
+        excludes:
+            # https://github.com/securego/gosec/issues/1185
+            - G115
+            # ignore imports, usages are still reported
+            - G501
+            - G502
+            - G503
+            - G504
+            - G505
 
     revive: # v1.2.3
         ignoreGeneratedHeader: true

diff --git a/snmpproxy/requester_test.go b/snmpproxy/requester_test.go
@@ -43,7 +43,7 @@ func TestMain(m *testing.M) {
 
 	// #nosec
 	cmd := exec.Command(
-		"snmpsimd.py",
+		"snmpsim-command-responder-lite",
 		"--v2c-arch",
 		"--data-dir", path.Join(wd, "test_data"),
 		"--agent-udpv4-endpoint", "127.0.0.1:15728",