ews: fix std::optional access before initialization

References: GXH-102, GXF-1734
grommunio · Aug 21, 2024 · f1d7ee1 · f1d7ee1
1 parent db4c838
commit f1d7ee1
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/exch/ews/requests.cpp b/exch/ews/requests.cpp
@@ -234,15 +234,13 @@ void process(mCreateItemRequest&& request, XMLElement* response, const EWSContex
 
 	mCreateItemResponse data;
 
-	bool hasAccess = true;
 	std::optional<sFolderSpec> targetFolder;
 	if(request.SavedItemFolderId)
 		targetFolder = ctx.resolveFolder(request.SavedItemFolderId->folderId);
-	std::string dir = ctx.getDir(*targetFolder);
-	if(!targetFolder)
-		targetFolder = ctx.resolveFolder(tDistinguishedFolderId("outbox"));
 	else
-		hasAccess = ctx.permissions(dir, targetFolder->folderId) & (frightsOwner | frightsCreate);
+		targetFolder = ctx.resolveFolder(tDistinguishedFolderId("outbox"));
+	std::string dir = ctx.getDir(*targetFolder);
+	bool hasAccess = ctx.permissions(dir, targetFolder->folderId) & (frightsOwner | frightsCreate);
 
 	if(!request.MessageDisposition)
 		request.MessageDisposition = Enum::SaveOnly;