oxvcard: emit VERSION line before other fields

vCard 3.0 did not specify the order of fields, but vCard 4.0 (RFC 6350 §7.9) does. Fixes: gromox-0.6-10-g9184f78c6 References: GXF-1213
grommunio · Oct 18, 2023 · b2a555b · b2a555b
1 parent 235f2a7
commit b2a555b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/doc/changelog.rst b/doc/changelog.rst
@@ -1,3 +1,12 @@
+Development 2.15.1
+==================
+
+Fixes:
+
+* oxvcard: export to .vcf now positions the VERSION property in accordance with
+  the vCard 4.0 specification.
+
+
 Gromox 2.15 (2023-10-18)
 ========================
 

diff --git a/lib/mapi/oxvcard.cpp b/lib/mapi/oxvcard.cpp
@@ -722,8 +722,8 @@ BOOL oxvcard_export(MESSAGE_CONTENT *pmsg, vcard &vcard, GET_PROPIDS get_propids
 	if (!oxvcard_get_propids(&propids, std::move(get_propids)))
 		return FALSE;
 	vcard.clear();
-	vcard.append_line("PROFILE", "VCARD");
 	vcard.append_line("VERSION", "4.0");
+	vcard.append_line("PROFILE", "VCARD");
 	vcard.append_line("MAILER", "gromox-oxvcard");
 	vcard.append_line("PRODID", "gromox-oxvcard");