Automatically connect to grisp.io #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziopio
force-pushed
the
ziopio/auto-connect
branch
from
3934738
to
b548033
Compare
peerst
requested changes
Jan 25, 2024
ziopio
force-pushed
the
ziopio/auto-connect
branch
from
b548033
to
f5aded4
Compare
|
I am going to adjust a couple of things to solve the merge conflict with the WS refactoring then I'll squash. |
ziopio
force-pushed
the
ziopio/auto-connect
branch
from
f5aded4
to
1b6d77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gen_statem is there to mainly automate what was previously done manually.
State machine is quite simple, is just a sequence that can loop in case it disconnects.
idle -> waiting_ip -> connecting -> connected -> waiting_ip ....
The option
{connect, true / false}controlls whether the gen_statem should connect or not.The gen_statem is always started under the top app supervisor.
The user can either leave the default
{connect, true}and have this process attempt to connect as soon as it is started.If
{connect, false}is set in the sys.config, then it can always be started withgrisp_io_connection:connect()I noticed that on Wifi WPA supplicant can be slow and the IP can take even 5+ seconds to be set after the app is booted. So if we serve logs to the user, is nice to wait for the IP instead of keep crashing on errors.