Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest removal of the mod_python command #139

Open
msquire opened this issue Sep 6, 2024 · 2 comments
Open

Suggest removal of the mod_python command #139

msquire opened this issue Sep 6, 2024 · 2 comments

Comments

@msquire
Copy link

msquire commented Sep 6, 2024

I discovered a mod_python command installed in /usr/bin and that it was a bit broken. I started to fix it to work with python 3.12 and recent versions of apache2 (the attached diff) but found that it depended on python's execfile() function which is a relic of python 2 - it was removed in python 3.0. Since it could never have worked properly with python 3, and no one has complained about it, I wonder if it might be better just to remove it altogether.

If you do want to keep it the attached diff got it working again for me - though I think it could probably do with a bit more work.

What do you think?

fix_mod_python_cmd.diff.gz

@grisha
Copy link
Owner

grisha commented Sep 6, 2024

I'm not ready to concede that it cannot be made to work with python 3 :)

I'll keep this issue around maybe some day we'll get it fixed or determine that it should be deprecated.

@msquire
Copy link
Author

msquire commented Sep 6, 2024

Oh, it can definitely be made to work with python 3. The patch I attached fixes that :) Or at least it "fixed it for me" on my particular setup (vanilla Ubuntu noble installation). I didn't spend any more time improving it beyond compatibility fixes because I wasn't sure if it would remain.

The question was only how useful the script is in practice if no one's noticed it was broken in python 3. I don't know if its a case of people not using it because it's broken, or people not noticing it's broken because they aren't using it.

Anyway, you are probably right to keep it because no doubt someone somewhere is using it and will complain if it disappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants