Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apacheHttpdPackages.mod_python: fix build with python3.12 #353031

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

zi3m5f
Copy link
Contributor

@zi3m5f zi3m5f commented Nov 2, 2024

ZHF: #352882

Build log: https://hydra.nixos.org/build/276557116/nixlog/1

adding distutils, packaging and setuptools to fix:

  • ModuleNotFoundError: No module named 'distutils'
  • ModuleNotFoundError: No module named 'packaging'
  • error: invalid command 'install'

and ensureNewerSourcesForZipFilesHook for:

  • ValueError: ZIP does not support timestamps before 1980

This fixes the build but bin/mod_python seems to be not working for a while at least in master and nixos-24.05. (grisha/mod_python#139)

@anthonyroussel: I saw you made the last changes, might you have a look?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

adding distutils, packaging and setuptools to fix:
- ModuleNotFoundError: No module named 'distutils'
- ModuleNotFoundError: No module named 'packaging'
- error: invalid command 'install'

and ensureNewerSourcesForZipFilesHook for:
- ValueError: ZIP does not support timestamps before 1980
@wegank wegank merged commit e7168d0 into NixOS:master Nov 2, 2024
29 of 30 checks passed
@zi3m5f zi3m5f deleted the mod_python-fix branch November 2, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants