feature: restore part #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for both js and java GF256 interpolation can take optional partIdx param that can be used to recreate part at that index Scheme class gets restorePart idx to restore lost or corrupted part from minimu required original parts
dmitry-salnikov
approved these changes
Mar 14, 2024
src/main/js/Scheme.js
Outdated
| const lengths = Object.values(parts).map(x => x.length); | ||
| const max = Math.max.apply(null, lengths); | ||
| const min = Math.min.apply(null, lengths); | ||
| if (max !== min) {`` |
| @@ -126,6 +128,35 @@ void splitAndJoinInquorate() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| void restorePartRoundtrip() { | |||
There was a problem hiding this comment.
wow, nice! how do you execute these tests?
There was a problem hiding this comment.
mvn test
but i don't have maven localy installed
maven is gradle's predecessor
pavlo-liapin
approved these changes
Mar 14, 2024
src/test/js/SchemeTests.js
Outdated
| const partsToRestoreFrom = { '1': splits['1'], '2': splits['2'] }; | ||
| const restoredPart = restorePart(partsToRestoreFrom, 3); | ||
| const splitsWithRestored = {'1': splits['1'], '3': restoredPart}; | ||
| const joined = bytesToSring(join(splitsWithRestored)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for both js and java
GF256 interpolation can take optional partIdx param that can be used to recreate part at that index
Scheme class gets restorePart idx to
restore lost or corrupted part from
minimum required original parts