Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: min_intron_length_ accidentally initialized from anchor (not intron) length parameter #188

Open
TimD1 opened this issue Jul 1, 2024 · 0 comments · May be fixed by #193
Open

Bug: min_intron_length_ accidentally initialized from anchor (not intron) length parameter #188

TimD1 opened this issue Jul 1, 2024 · 0 comments · May be fixed by #193

Comments

@TimD1
Copy link

TimD1 commented Jul 1, 2024

Improper JunctionsExtractor initialization:

regtools/src/junctions/junctions_extractor.h

Line 200 in c1ba2a2

bam_(bam1), region_(region1), strandness_(strandness1), strand_tag_(strand_tag1), min_anchor_length_(min_anchor_length1), min_intron_length_(min_anchor_length1), max_intron_length_(max_intron_length1), ref_(ref1){

TimD1 added a commit to fulcrumgenomics/regtools that referenced this issue Jul 1, 2024
@TimD1
fix: min_intron_length_ initialization in JunctionsExtractor
e82f1e4 
 - fixes griffithlab#188, min_intron_length_ was accidentaly set from min_anchor_len_
TimD1 added a commit to fulcrumgenomics/regtools that referenced this issue Jul 2, 2024
@TimD1
fix: min_intron_length_ initialization in JunctionsExtractor
0a9373a 
 - fixes griffithlab#188, min_intron_length_ was accidentaly set from min_anchor_len_
TimD1 added a commit to fulcrumgenomics/regtools that referenced this issue Sep 19, 2024
@TimD1
fix: min_intron_length_ initialization in JunctionsExtractor
1260bf9 
 - fixes griffithlab#188, min_intron_length_ was accidentally set from min_anchor_len_
TimD1 added a commit to fulcrumgenomics/regtools that referenced this issue Sep 19, 2024
@TimD1
fix: min_intron_length_ initialization in JunctionsExtractor
b82980e 
 - fixes griffithlab#188, min_intron_length_ was accidentally set from min_anchor_len_
@TimD1 TimD1 linked a pull request Sep 19, 2024 that will close this issue
Open
TimD1 added a commit to fulcrumgenomics/regtools that referenced this issue Sep 19, 2024
@TimD1
fix: min_intron_length_ initialization in JunctionsExtractor
7a02ffa 
 - fixes griffithlab#188, min_intron_length_ was accidentally set from min_anchor_len_
@TimD1 TimD1 mentioned this issue Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: min_intron_length initialization in JunctionsExtractor fulcrumgenomics/regtools
1 participant
@TimD1