Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: junctions extractor count overlapping read pairs once #196

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TimD1
Copy link

@TimD1 TimD1 commented Sep 19, 2024

 - closes griffithlab#176, CMake was including `src/utils/bedtools/gzstream/version`
   as a C++ source file, when it was a simple text file containing version info
 - I moved this version info into `src/utils/bedtools/gzstream/README`
 - fixes griffithlab#188, min_intron_length_ was accidentally set from min_anchor_len_
 - closes griffithlab#183, flag based filtering
 - closes griffithlab#189, mapping quality based filtering
 - option '-F' filters reads containing any of these flags
 - option '-f' filters reads not containing all these flags
 - option '-q' filters reads below this mapping quality
 - closes griffithlab#186, reads now only 'support' a junction if they have at least
   a given minimum anchor length, supplied with the '-A' flag (default 0)
 - closes griffithlab#187, implemented by adding set of `reads` to `Junction`, and
   only incrementing `read_count` if read has not been seen yet
 - this commit should also increase RegTools speed by removing the barcode
   updating bottleneck caused by repeatedly copying the barcode map
 - updated regtools to v1.1.0
@santataRU
Copy link

Dear TimD1,

Is the source code for Regtools version 1.1.0 available for download? I am currently using version 1.0.0 and would like to access the updated version so that the Regtools junctions extractor counts overlapping read pairs only once.

Thank you for your help.

Best regards,
Xiao

@TimD1
Copy link
Author

TimD1 commented Oct 25, 2024

The source code that counts overlapping read pairs only once is available from my fork of RegTools, at: https://github.com/fulcrumgenomics/regtools/tree/187/td/no-double-read-support

However, please note that this is not an official RegTools v1.1.0 release (I just suggested bumping the version due to several command-line parameter changes) and there are no guarantees on this fork being supported/maintained (it was only created to make this batch of PRs).

@santataRU
Copy link

The source code that counts overlapping read pairs only once is available from my fork of RegTools, at: https://github.com/fulcrumgenomics/regtools/tree/187/td/no-double-read-support

However, please note that this is not an official RegTools v1.1.0 release (I just suggested bumping the version due to several command-line parameter changes) and there are no guarantees on this fork being supported/maintained (it was only created to make this batch of PRs).

Hi, Tim,

Thank you very much for your help. Does this version address the strandedness issue mentioned in this post (#197)?

Xiao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug report: junction extract tool should not count overlapping reads as double support for a junction
2 participants