Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete unused endpoint (voltage-levelsequipments) #473

Merged
merged 6 commits into from
Apr 11, 2024
Merged

delete unused endpoint (voltage-levelsequipments) #473

merged 6 commits into from
Apr 11, 2024

Conversation

achour94
Copy link
Contributor

No description provided.

@achour94 achour94 requested a review from SlimaneAmar November 14, 2023 14:30
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SlimaneAmar SlimaneAmar requested review from souissimai and jamal-khey and removed request for SlimaneAmar March 28, 2024 07:54
jamal-khey
jamal-khey approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one remark, the PR title do not match the content
should probably be 'rename voltage-level-equipments endpoint' not delete unused endpoint

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SlimaneAmar SlimaneAmar merged commit 9c90c72 into main Apr 11, 2024
3 checks passed
@SlimaneAmar SlimaneAmar deleted the remove_toMapData branch April 11, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souissimai souissimai souissimai approved these changes

@jamal-khey jamal-khey jamal-khey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achour94 @jamal-khey @souissimai @SlimaneAmar