logs on demand #455
Merged
logs on demand #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbraquart
force-pushed
the
wip_logs_on_demand
branch
from
bd1df18 to
52e7446
Compare
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
…d taskKey filter Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
wip_logs_on_demand
branch
from
ad6cc33 to
4599e6f
Compare
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
wip_logs_on_demand
branch
from
7af2737 to
868ed1a
Compare
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
wip_logs_on_demand
branch
from
09bdec6 to
5cc284e
Compare
src/main/java/org/gridsuite/study/server/service/StudyService.java
Outdated
Show resolved
Hide resolved
| .addHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE); | ||
| .setBody(mapper.writeValueAsString(getNodeReport(Objects.requireNonNull(request.getRequestUrl()).pathSegments().get(2), request.getRequestUrl().queryParameter(QUERY_PARAM_REPORT_DEFAULT_NAME)).getSubReporters())) | ||
| .addHeader(HttpHeaders.CONTENT_TYPE, MediaType.APPLICATION_JSON_VALUE); | ||
| } else if (path.matches("/v1/subreports/.*\\?severityLevels=.*")) { |
There was a problem hiding this comment.
Is it worth it to include & in these patterns, in case we have something like /v1/reports/1234?hello=true&defaultName ?
There was a problem hiding this comment.
I dont get this comment
There was a problem hiding this comment.
The current regex will only match if severityLevels is the first parameter in the URL. If it is the second, then it would match "&severityLevel=" instead of "?severityLevel="
There was a problem hiding this comment.
ok, I get it.
But we have only one param currently, so severityLevels is always first.
Signed-off-by: David BRAQUART <[email protected]>
SlimaneAmar
approved these changes
Oct 30, 2023
Signed-off-by: Slimane AMAR <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
wip_logs_on_demand
branch
from
5c813ab to
7f9e9b7
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works only with branch logs_optimization from report-server (no PR at this time)