-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set inUpstreamBuiltParentNode to false by default for get equipement … #446
set inUpstreamBuiltParentNode to false by default for get equipement … #446
Conversation
3ad5216
to
7abc50d
Compare
Signed-off-by: jamal-khey <[email protected]>
7abc50d
to
7327f27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some API calls that rely on the inUpstreamBuildParentNode set to true. We should check carefully each call and decide whether or not inUpstreamBuildParentNode should be set to true.
With the changes, I have an internal error 500 when I try to delete an HVDC line on a node that is not built. I have no issues when I'm on the main branch. See Antoine/test/recollement on dev-OPF as an example. I think there are other calls that might be problematic. I only tested https://github.com/gridsuite/gridstudy-app/blob/c77dadb572feb8d092981851de3fc4b001498226/src/services/study/network-map.js#L22.
after a discution with Christelle , it has been decided to keep this parameter to true for the end point. |
Signed-off-by: jamal-khey <[email protected]>
0c81377
to
b09bebf
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
set all end points that use inUpstreamBuiltParentNode=true as a default value to'true'