Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set inUpstreamBuiltParentNode to false by default for get equipement … #446

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

jamal-khey
Copy link
Contributor

@jamal-khey jamal-khey commented Oct 2, 2023

set all end points that use inUpstreamBuiltParentNode=true as a default value to'true'

@jamal-khey jamal-khey requested a review from SlimaneAmar October 2, 2023 22:20
@jamal-khey jamal-khey self-assigned this Oct 3, 2023
@jamal-khey jamal-khey force-pushed the inUpstreamBuiltParentNode-to-false-by-default branch from 3ad5216 to 7abc50d Compare October 4, 2023 10:00
@antoinebhs antoinebhs self-requested a review October 16, 2023 12:57
jamal-khey added a commit that referenced this pull request Oct 16, 2023
@jamal-khey jamal-khey force-pushed the inUpstreamBuiltParentNode-to-false-by-default branch from 7abc50d to 7327f27 Compare October 16, 2023 13:33
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some API calls that rely on the inUpstreamBuildParentNode set to true. We should check carefully each call and decide whether or not inUpstreamBuildParentNode should be set to true.
With the changes, I have an internal error 500 when I try to delete an HVDC line on a node that is not built. I have no issues when I'm on the main branch. See Antoine/test/recollement on dev-OPF as an example. I think there are other calls that might be problematic. I only tested https://github.com/gridsuite/gridstudy-app/blob/c77dadb572feb8d092981851de3fc4b001498226/src/services/study/network-map.js#L22.

@jamal-khey
Copy link
Contributor Author

There are some API calls that rely on the inUpstreamBuildParentNode set to true. We should check carefully each call and decide whether or not inUpstreamBuildParentNode should be set to true. With the changes, I have an internal error 500 when I try to delete an HVDC line on a node that is not built. I have no issues when I'm on the main branch. See Antoine/test/recollement on dev-OPF as an example. I think there are other calls that might be problematic. I only tested https://github.com/gridsuite/gridstudy-app/blob/c77dadb572feb8d092981851de3fc4b001498226/src/services/study/network-map.js#L22.

after a discution with Christelle , it has been decided to keep this parameter to true for the end point.

@jamal-khey jamal-khey force-pushed the inUpstreamBuiltParentNode-to-false-by-default branch from 0c81377 to b09bebf Compare October 19, 2023 09:31
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jamal-khey jamal-khey merged commit 4915678 into main Nov 8, 2023
4 checks passed
@jamal-khey jamal-khey deleted the inUpstreamBuiltParentNode-to-false-by-default branch November 8, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants