Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutualized api functions #440

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Meklo
Copy link
Contributor

@Meklo Meklo commented Jun 6, 2024

Need #475

Depends on gridsuite/commons-ui#455

@Meklo Meklo changed the base branch from main to feat/remove_directory_api_call June 6, 2024 14:42
@Meklo Meklo changed the title Remove mutualized utils functions Remove mutualized ws functions Jun 7, 2024
@Meklo Meklo changed the title Remove mutualized ws functions Remove mutualized api functions Jun 7, 2024
Base automatically changed from feat/remove_directory_api_call to main June 7, 2024 14:26
@Meklo Meklo requested a review from Tristan-WorkGH June 18, 2024 13:55
@dbraquart dbraquart self-requested a review July 3, 2024 15:00
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: elementExists to remove
tests: partially done, sounds OK. To be continued after merge wConflcts + CR

@@ -783,13 +778,8 @@ const ContentContextualMenu = (props) => {
activeElement.specificMetadata.equipmentType,
}}
activeDirectory={activeDirectory}
fetchAppsAndUrls={fetchAppsAndUrls}
elementExists={elementExists}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elementExists is no more part of this component in commons-ui

@@ -384,12 +380,8 @@ const DirectoryTreeContextualMenu = (props) => {
open={true}
onClose={handleCloseDialog}
activeDirectory={activeDirectory}
fetchAppsAndUrls={fetchAppsAndUrls}
elementExists={elementExists}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, many places where we have to remove elementExists prop

@@ -10,7 +10,13 @@ import { store } from '../redux/store';
import ReconnectingWebSocket from 'reconnecting-websocket';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elementExists should be removed from here

@Tristan-WorkGH Tristan-WorkGH force-pushed the feat/remove_fetch_utils branch from 09b8cf0 to 0140385 Compare August 12, 2024 23:18
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants