Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gateway control. #107

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Remove gateway control. #107

merged 2 commits into from
Jul 19, 2024

Conversation

AAJELLAL
Copy link
Contributor

@AAJELLAL AAJELLAL commented Jul 5, 2024

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sBouzols sBouzols self-requested a review July 9, 2024 16:02
sBouzols
sBouzols approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@sBouzols sBouzols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review OK
Tests OK
We accept to remove those controls for now, but must be reimplement in another way in the future.

@AAJELLAL AAJELLAL merged commit 6627e41 into main Jul 19, 2024
3 checks passed
@AAJELLAL AAJELLAL deleted the delete-control-access branch July 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sBouzols sBouzols sBouzols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AAJELLAL @sBouzols