Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor routes init and add tests #100

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Tristan-WorkGH
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH commented Apr 23, 2024

Some refactors:

  • in GatewayConfig for bean myRoutes, no need to get manually each EndPointServer in Spring context, Spring can do it for us
    • add a test to check all EndPointServer are detected and set
  • add test to check that filters are initialized and in correct order
  • AbstractGlobalPreFilter don't need to be public, pass to package-only visibility
  • remove redudant ExploreServer.hasElementsAccessControl having same body than parent EndPointElementServer
  • fix some typos

@Tristan-WorkGH Tristan-WorkGH self-assigned this Apr 23, 2024
@Tristan-WorkGH Tristan-WorkGH changed the title Gateway/refactor Refactor routes init and add tests Apr 23, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant