Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for expert filter evaluation #99

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

FranckLecuyer
Copy link
Contributor

No description provided.

Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the sonar issues are straight forward to fix, we should use this refacto to fix them even if I know that most of them were already present in the code

@@ -107,4 +131,496 @@ public static boolean isRangeNominalVoltage(Double nominalV, Double minValue, Do
public static boolean isEnergySource(Generator generator, String energySource) {
return generator.getEnergySource().name().equalsIgnoreCase(energySource);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add these methods to another file to avoid polluting this one? FilterServiceUtils?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (only 2 public methods called in FilterService put on new FilterServiceUtils class)

@FranckLecuyer
Copy link
Contributor Author

Most of the sonar issues are straight forward to fix, we should use this refacto to fix them even if I know that most of them were already present in the code

Done

Copy link

@FranckLecuyer FranckLecuyer merged commit d840026 into main Mar 12, 2024
3 checks passed
@FranckLecuyer FranckLecuyer deleted the refactor_evaluate_expert_filter branch March 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants