-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring for expert filter evaluation #99
Conversation
…n expert filter. Signed-off-by: Franck LECUYER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the sonar issues are straight forward to fix, we should use this refacto to fix them even if I know that most of them were already present in the code
@@ -107,4 +131,496 @@ public static boolean isRangeNominalVoltage(Double nominalV, Double minValue, Do | |||
public static boolean isEnergySource(Generator generator, String energySource) { | |||
return generator.getEnergySource().name().equalsIgnoreCase(energySource); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add these methods to another file to avoid polluting this one? FilterServiceUtils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (only 2 public methods called in FilterService put on new FilterServiceUtils class)
Signed-off-by: Franck LECUYER <[email protected]>
Signed-off-by: Franck LECUYER <[email protected]>
Done |
|
No description provided.