Fix access control for modifying filters and contingency lists #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AAJELLAL <[email protected]>
…to handle_access_rights # Conflicts: # src/main/java/org/gridsuite/explore/server/services/ExploreService.java
…-contingency-lists
|
souissimai
reviewed
Jan 22, 2025
| } catch (HttpStatusCodeException e) { | ||
| handleException(e); | ||
| } | ||
| if (response != null && HttpStatus.NO_CONTENT.equals(response.getStatusCode())) { |
There was a problem hiding this comment.
response
!= null is already true
souissimai
reviewed
Jan 22, 2025
| headers.add(HEADER_USER_ID, userId); | ||
|
|
||
| String path = UriComponentsBuilder.fromPath(ELEMENTS_SERVER_ROOT_PATH) | ||
| .queryParam(isUpdate ? PARAM_FOR_UPDATE : PARAM_FOR_DELETION, true) |
There was a problem hiding this comment.
use one param for both (deletion and update)
souissimai
reviewed
Jan 22, 2025
| if (HttpStatus.NO_CONTENT.equals(response.getStatusCode())) { | ||
| throw new ExploreException(NOT_ALLOWED); | ||
| } | ||
| checkPermission(elementUuids, userId, false); |
There was a problem hiding this comment.
areElementsAccessible instead checkPermission
|
TEST OK, small remarks |
sBouzols
reviewed
Jan 24, 2025
| @@ -350,6 +354,8 @@ public void notifyCasesThresholdReached(int userCasesCount, int userMaxAllowedSt | |||
| } | |||
|
|
|||
| public void updateElement(UUID id, ElementAttributes elementAttributes, String userId) { | |||
| // check if the user have the right to update the element | |||
| directoryService.areDirectoryElementsUpdatable(List.of(id), userId); | |||
There was a problem hiding this comment.
It's already done in the directory-server when calling updateElement and you don't have another service called than the directory-server here. Maybe keep a comment here but do not check multiple times I think ?
sBouzols
requested changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.