Rename composite modification methods #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dbraquart
requested changes
Jan 15, 2025
| @Operation(summary = "duplicate modification element") | ||
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Modifications have been duplicated and corresponding elements created in the directory")}) | ||
| public ResponseEntity<Void> duplicateNetworkModifications(@RequestParam("duplicateFrom") UUID networkModificationId, | ||
| public ResponseEntity<Void> duplicateCompositeNetworkModifications(@RequestParam("duplicateFrom") UUID networkModificationId, |
There was a problem hiding this comment.
Suggested change
| public ResponseEntity<Void> duplicateCompositeNetworkModifications(@RequestParam("duplicateFrom") UUID networkModificationId, | |
| public ResponseEntity<Void> duplicateCompositeNetworkModification(@RequestParam("duplicateFrom") UUID networkModificationId, |
| @RequestParam(name = QUERY_PARAM_PARENT_DIRECTORY_ID, required = false) UUID targetDirectoryId, | ||
| @RequestHeader(QUERY_PARAM_USER_ID) String userId) { | ||
| exploreService.duplicateNetworkModifications(networkModificationId, targetDirectoryId, userId); | ||
| exploreService.duplicateCompositeModifications(networkModificationId, targetDirectoryId, userId); |
There was a problem hiding this comment.
Suggested change
| exploreService.duplicateCompositeModifications(networkModificationId, targetDirectoryId, userId); | |
| exploreService.duplicateCompositeModification(networkModificationId, targetDirectoryId, userId); |
| ElementAttributes elementAttributes = new ElementAttributes(modificationsUuid, name, MODIFICATION, | ||
| userId, 0L, description); | ||
| directoryService.createElementWithNewName(elementAttributes, parentDirectoryUuid, userId, true); | ||
| } | ||
|
|
||
| public void duplicateNetworkModifications(UUID sourceId, UUID parentDirectoryUuid, String userId) { | ||
| public void duplicateCompositeModifications(UUID sourceId, UUID parentDirectoryUuid, String userId) { |
There was a problem hiding this comment.
Suggested change
| public void duplicateCompositeModifications(UUID sourceId, UUID parentDirectoryUuid, String userId) { | |
| public void duplicateCompositeModification(UUID sourceId, UUID parentDirectoryUuid, String userId) { |
| return ResponseEntity.ok().build(); | ||
| } | ||
|
|
||
| @PostMapping(value = "/explore/modifications", params = "duplicateFrom") | ||
| @PostMapping(value = "/explore/composite-modifications", params = "duplicateFrom") | ||
| @Operation(summary = "duplicate modification element") | ||
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Modifications have been duplicated and corresponding elements created in the directory")}) |
There was a problem hiding this comment.
Suggested change
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Modifications have been duplicated and corresponding elements created in the directory")}) | |
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Composite modification has been duplicated and corresponding element created in the directory")}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.