Skip to content

Commit

Permalink
bump canvas
Browse files Browse the repository at this point in the history
  • Loading branch information
softmarshmallow committed Dec 17, 2023
1 parent bea7ad1 commit 6259596
Show file tree
Hide file tree
Showing 3 changed files with 1,433 additions and 57 deletions.
30 changes: 26 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Integrated usage
- [@designto/cli](./cli)

## Supported Design Tools
We support importing designs from Figma with our [figma-sdk](https://github.com/gridaco/figma-sdk). You can also design components with [scenes](https://github.com/gridaco/scenes) DSL, or use our built-in drag & drop editor.

We support importing designs from Figma with our [figma-sdk](https://github.com/gridaco/figma-sdk). You can also design components with [scenes](https://github.com/gridaco/scenes) DSL, or use our built-in drag & drop editor.

## Platforms / Frameworks

Expand Down Expand Up @@ -163,17 +163,39 @@ Custom Cache
Custom Cursor
Plugins

### Local development
### Running locally

```
git clone https://github.com/gridaco/designto-code.git
cd designto-code
git clone https://github.com/gridaco/code.git
cd code
yarn
yarn editor
# visit http://localhost:6626
```

**Trouble shooting**

Our visual testing library uses node-canvas, which requires some additional dependencies. If you run into issues, please see the [node-canvas documentation](https://github.com/Automattic/node-canvas)

If you see error like this while installing dependencies,

```txt
node-pre-gyp ERR! node -v v18.17.0
node-pre-gyp ERR! node-pre-gyp -v v1.0.10
node-pre-gyp ERR! not ok
```

Try this

```bash
brew install pkg-config cairo pango libpng jpeg giflib librsvg pixman
brew install python@2 # since python2 is no longer available on brw, you can also use this link. https://www.python.org/downloads/release/python-2718/
```

- [Reference#2 / node-canvas/issues/1733](https://github.com/Automattic/node-canvas/issues/1733#issuecomment-761703018)
- [Reference#1 / node-canvas/issues/1662](https://github.com/Automattic/node-canvas/issues/1662#issuecomment-1465269869)

<details>
<summary>Trouble shooting</summary>

Expand Down
4 changes: 2 additions & 2 deletions testing/testing-diffview/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"version": "0.0.0",
"dependencies": {
"canvas": "^2.11.2",
"resemblejs": "^4.1.0"
"resemblejs": "^5.0.0"
},
"devDependencies": {
"@types/resemblejs": "^4.1.0"
"@types/resemblejs": "^4.1.3"
}
}
Loading

0 comments on commit 6259596

Please sign in to comment.