Adding targets #7
Open
+1,061
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request expands multiplatform support across various Wire project modules, focusing on native targets and build configurations.
- Added numerous native targets (Android, iOS, Linux, macOS, Windows, tvOS, watchOS, WebAssembly) in
wire-grpc-client/build.gradle.ktsandwire-runtime/build.gradle.kts - Changed
samples/js/build.gradle.ktsfromkotlin("js")tokotlin("multiplatform")for future platform expansion - Simplified JVM target configurations in
wire-schema-tests/build.gradle.ktsandwire-schema/build.gradle.kts - Added
wireRuntimeVariants.txtdetailing build variants and configurations for wire-runtime library
6 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
Comment on lines
40
to
+41
| iosSimulatorArm64() | ||
| // Required to generate tests tasks: https://youtrack.jetbrains.com/issue/KT-26547 | ||
| linuxX64() | ||
| macosX64() | ||
| iosSimulatorArm64() |
There was a problem hiding this comment.
logic: iosSimulatorArm64() is duplicated on lines 40 and 41
Comment on lines
+103
to
+104
| iosSimulatorArm64Main, | ||
| iosSimulatorArm64Main, |
There was a problem hiding this comment.
logic: iosSimulatorArm64Main is duplicated in the list
| it.dependsOn(nativeTest) | ||
| } | ||
|
|
||
| for (it in listOf(iosX64Main, iosArm64Main, macosX64Main, macosArm64Main, tvosX64Main, tvosArm64Main)) { | ||
| for (it in listOf( |
There was a problem hiding this comment.
logic: The darwinMain source set is being used for non-Darwin platforms. Consider creating a separate source set for Android and Linux targets.
| @@ -36,18 +35,30 @@ kotlin { | |||
| } | |||
| } | |||
| if (System.getProperty("knative", "true").toBoolean()) { | |||
There was a problem hiding this comment.
style: Consider grouping targets by platform (e.g., iOS, tvOS, watchOS) for better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.