CompileOnly for the KGP in wire-gradle-plugin #3
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the Wire Gradle plugin configuration and test projects, focusing on dependency management and build settings. Key changes include:
- Modified
wire-gradle-plugin/build.gradle.ktsto use 'compileOnly' for Kotlin Gradle Plugin dependency - Updated test projects to use version catalogs for plugin versions
- Added new
settings.gradle.ktsfiles for build cache configuration in test projects - Removed old
settings.gradlefiles from test projects - Updated
WirePluginTest.ktto accommodate changes in plugin behavior and configuration
These changes aim to improve the plugin's build process, test setup, and version management across the Wire project.
30 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings
| @@ -35,14 +35,15 @@ gradlePlugin { | |||
| dependencies { | |||
| compileOnly(gradleApi()) | |||
| compileOnly(libs.pluginz.android) | |||
| compileOnly(libs.pluginz.kotlin) | |||
There was a problem hiding this comment.
logic: Moving KGP to compileOnly may cause issues if the plugin relies on KGP classes at runtime
| dependsOn(":wire-schema:publishAllPublicationsToLocalMavenRepository") | ||
| dependsOn(":wire-grpc-client:publishAllPublicationsToLocalMavenRepository") | ||
| dependsOn(":wire-compiler:publishAllPublicationsToLocalMavenRepository") | ||
| dependsOn(":wire-gradle-plugin:publishAllPublicationsToLocalMavenRepository") |
There was a problem hiding this comment.
logic: Circular dependency: wire-gradle-plugin depends on itself for tests
There was a problem hiding this comment.
logic: Removing buildCache configuration may affect test behavior. Ensure this is intentional.
There was a problem hiding this comment.
logic: Removing the build cache configuration may affect caching behavior in tests. Ensure this is intentional and doesn't break any caching-related tests.
| @@ -0,0 +1,24 @@ | |||
| buildCache { | |||
| local { | |||
| directory = File(rootDir, "../.cache-include-paths-build-cache") | |||
There was a problem hiding this comment.
style: Using a relative path for the build cache directory may cause issues if the project structure changes
| it.apply { | ||
| mavenCentral() | ||
| maven { | ||
| url = uri(rootDir.resolve("../../../../../build/localMaven").absolutePath) |
There was a problem hiding this comment.
style: Absolute path for local Maven repository reduces build portability
| dependencyResolutionManagement { | ||
| versionCatalogs { | ||
| create("libs") { | ||
| from(files(rootDir.resolve("../../../../../gradle/libs.versions.toml").absolutePath)) |
There was a problem hiding this comment.
style: Absolute path for version catalog file may cause issues in different environments
| id 'org.jetbrains.kotlin.jvm' version libs.versions.kotlin | ||
| id 'com.squareup.wire' version "$wireVersion" |
There was a problem hiding this comment.
style: Consider using the same version declaration style for both plugins for consistency
| id("com.squareup.wire") version("$wireVersion") | ||
| id("org.jetbrains.kotlin.jvm") version libs.versions.kotlin |
There was a problem hiding this comment.
style: Consider using the same version declaration style for both plugins for consistency
| id 'org.jetbrains.kotlin.jvm' version libs.versions.kotlin | ||
| id 'com.squareup.wire' version "$wireVersion" |
There was a problem hiding this comment.
style: Consider using the same version declaration style for both plugins for consistency
No description provided.