Swift: encode & decode size-delimited messages #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces size-delimited message encoding and decoding functionality to the Swift runtime for Wire, enhancing compatibility with protocols like Bazel's Build Event Protocol.
- Added
decodeSizeDelimitedmethod inProtoDecoder.swiftto handle varint-prefixed message collections - Implemented
encodeSizeDelimitedinProtoEncoder.swiftfor efficient encoding of message arrays with size delimiters - Enhanced
WriteBuffer.swiftwith empty data checks for improved efficiency - Added comprehensive test cases in
ProtoDecoderTests.swift,ProtoEncoderTests.swift,RoundTripTests.swift, andWriteBufferTests.swiftto verify new functionality
7 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
Comment on lines
+180
to
+181
| while fullBuffer.isDataRemaining, let size = try? fullBuffer.readVarint64() { | ||
| if size == 0 { break } |
There was a problem hiding this comment.
logic: Breaking on size 0 might skip valid empty messages. Consider handling this case explicitly
| @@ -74,13 +78,17 @@ final class WriteBuffer { | |||
|
|
|||
| func append(_ value: WriteBuffer) { | |||
| precondition(value !== self) | |||
| guard value.count > 0 else { return } | |||
There was a problem hiding this comment.
style: Consider using isEmpty instead of count > 0 for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to encode and decode a size-delimited message collection in Swift.
The intended use case is to decode a stream of messages recorded to disk (e.g., Bazel's Build Event Protocol). Similar implementations exist in Java (writeDelimitedTo and parseDelimitedFrom) and other languages in protocolbuffers/protobuf#10229.