Allow namespace star #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces a breaking change to the AST format, allowing the use of '*' as a namespace scope in Thrift files.
- Modified
parseNamespaceScopeinsrc/main/parser.tsto handle '*' and identifier tokens - Added
createNamespaceScopefunction insrc/main/factory.tsfor creatingNamespaceScopeobjects - Updated
src/main/scanner.tsto recognize '*' as a StarToken - Introduced
NamespaceScopeinterface insrc/main/types.ts, replacingIdentifierfor namespace scopes - Updated test fixtures and solutions in
src/tests/parser/to reflect the new AST structure
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
| @@ -394,18 +396,32 @@ export function createParser( | |||
| return null | |||
| } | |||
|
|
|||
| // NamespaceScope → '*' | Identifier | |||
There was a problem hiding this comment.
style: Consider adding a comment explaining the purpose of this function
Comment on lines
+401
to
+405
| if (currentToken().type === SyntaxType.StarToken) { | ||
| const loc = currentToken().loc | ||
| advance() | ||
| return createNamespaceScope('*', loc) | ||
| } |
There was a problem hiding this comment.
logic: Check for SyntaxType.StarToken before consuming
| `Unable to find scope identifier for namespace`, | ||
| ) | ||
|
|
||
| const scope: NamespaceScope = parseNamespaceScope() |
There was a problem hiding this comment.
logic: Add error handling for invalid namespace scopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** This is a breaking change, it changes the format of the AST **
Closes creditkarma#65