Implement cpp_include parser #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements parsing for 'cpp_include' statements in Thrift files, enhancing the parser's compatibility with Thrift documents that use C++ include directives.
- Added
parseCppInclude()function insrc/main/parser.tsto handle cpp_include statements - Implemented storage and organization of CppIncludeDefinition objects in
src/main/organizer.ts - Created new test fixture
cpp_include.thriftand corresponding solution JSON for validation - Added a test case in
parser.spec.tsto ensure correct parsing of cpp_include syntax - Updated
parseStatement()andisStatementBeginning()functions to recognize cpp_include keywords
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+38
to
44
| case SyntaxType.CppIncludeDefinition: | ||
| cppIncludes.push(next) | ||
| break | ||
|
|
||
| case SyntaxType.CppIncludeDefinition: | ||
| // We're not generating C++ | ||
| break |
There was a problem hiding this comment.
logic: Duplicate case for SyntaxType.CppIncludeDefinition. Remove the second case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the current version does not include the implementation of
cpp_includeentries and it throws an error when running into it. This PR implements the parsing logic forcpp_include. It mimics the code forincludesyntax.