[WIP]: Implement backup resource #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kobi Samoray <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements a new resource for NSX-T Policy Backup Configuration, allowing users to manage automated backups through Terraform.
- Added
nsxt_policy_backup_configresource innsxt/resource_nsxt_policy_backup_config.gowith CRUD operations and schema definition - Implemented basic acceptance test in
nsxt/resource_nsxt_policy_backup_config_test.go - Created documentation for the new resource in
website/docs/r/policy_backup_config.html.markdown - Registered the new resource in the provider's ResourcesMap in
nsxt/provider.go
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
Comment on lines
+198
to
+200
| func resourceNsxtPolicyBackupConfigCreate(d *schema.ResourceData, m interface{}) error { | ||
| return resourceNsxtPolicyBackupConfigUpdate(d, m) | ||
| } |
There was a problem hiding this comment.
logic: Create function directly calls Update. Consider adding a separate implementation for Create if needed
| return handleReadError(d, "PolicyBackupConfig", "", err) | ||
| } | ||
| d.Set("inventory_summary_interval", obj.InventorySummaryInterval) | ||
| d.Set("passphrase", obj.Passphrase) |
There was a problem hiding this comment.
style: Avoid setting sensitive data like passphrase in state
| The following arguments are supported: | ||
|
|
||
| * `after_inventory_update_interval` - (Optional) A number of seconds after a last backup, that needs to pass, before a topology change will trigger a generation of a new cluster/node backups. | ||
| * `backup_enabled` - (Optional) true if automated backup is enabled. Default is false. |
There was a problem hiding this comment.
style: Capitalize 'true' for consistency with Terraform syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.