Check that target version is set #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade state can be erased in NSX due to various reasons, e.g restoration from backup. In this case the TF state could allow execution of the nsxt_upgrade_run resource even though there is no ongoing backup. This case should be properly handled instead of failing with a SIGSEGV. Signed-off-by: Kobi Samoray <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a nil check for the target version in the nsxt_upgrade_run resource to handle cases where the upgrade state has been erased in NSX.
- Added error handling in
getTargetVersionfunction whenobj.TargetVersionis nil - Prevents potential SIGSEGV errors by returning a descriptive error message
- Improves robustness of the upgrade process when NSX state is inconsistent
- Suggests restarting the upgrade process with a clean state when target version is missing
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade state can be erased in NSX due to various reasons, e.g restoration from backup. In this case the TF state could allow execution of the nsxt_upgrade_run resource even though there is no ongoing backup.
This case should be properly handled instead of failing with a SIGSEGV.