Handle VLCM upgrade as potentially partial #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When host upgrade is done with VLCM, there is the possibility that host upgrade will not be concluded and then, result will be a paused state. This case should be handled as partial upgrade. Signed-off-by: Kobi Samoray <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request enhances the NSX-T Terraform provider's upgrade functionality to handle VLCM (vSphere Lifecycle Manager) upgrades more accurately:
- Modifies
nsxt/resource_nsxt_upgrade_run.goto treat 'stage_in_vlcm' upgrade mode as a partial upgrade - Ensures upgrades with 'stage_in_vlcm' mode are properly managed and reported, potentially resulting in a paused state
- Improves compatibility with VLCM-based upgrade processes in vSphere environments
- Addresses scenarios where host upgrades may not complete, leading to a paused state in the upgrade process
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When host upgrade is done with VLCM, there is the possibility that host upgrade will not be concluded and then, result will be a paused state. This case should be handled as partial upgrade.