[CMSP-217] Accept siteID key as either int or string

[lizard-boy]

As part of implementing pantheon-systems/terminus-yml-validator-plugin#1, I discovered it is difficult, if not impossible, for PHP to differentiate between siteID keys being an int, or a string that could be cast to an int.

Rather than jumping through a lot of hoops on the PHP side, I opted to make the go validator a bit more flexible.

TODO:

• assert how the search-replace script behaves if the key is an int in one case and a string in the other, and adapt accordingly (this can be done as part of upgrading sites-yml-validator in the job worker and does not need to block PR).

[greptile-apps]

PR Summary

This pull request modifies the sites-yml-validator to accept site IDs as either integers or strings in YAML configurations, addressing difficulties in PHP differentiating between integer and string keys.

• Modified pkg/model/sites.go to use string keys for DomainMapByEnvironment type
• Updated pkg/validator/sites.go with new isValidSiteID function to validate site IDs
• Added new test cases in pkg/validator/sites_test.go for string-based site IDs
• Introduced new fixture files valid_both_string_and_int_key.yml and valid_string_as_key.yml to test mixed and string-only site ID representations

_{5 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

style: Inconsistent key formatting for site IDs. Consider using quotes for all keys for consistency.

[greptile-apps]

style: Ensure consistent quoting style for all string keys

[greptile-apps]

style: This check might reject valid site IDs like '0123'. Consider using a regex to check for leading zeros instead