[PM-13717] Fix legacy credit rebate for migrated MSPs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| await stripeAdapter.CustomerUpdateAsync(provider.GatewayCustomerId, new CustomerUpdateOptions | ||
| if (legacyOrganizationCredit < 0) |
There was a problem hiding this comment.
logic: This condition might prevent applying positive credits. Consider if this is the intended behavior.
|
|
||
| logger.LogInformation("CB: Applied {Credit} credit to provider ({ProviderID})", organizationCancellationCredit, provider.Id); | ||
| logger.LogInformation("CB: Applied {Credit} credit to provider ({ProviderID})", organizationCancellationCredit + legacyOrganizationCredit, provider.Id); |
There was a problem hiding this comment.
style: Update the log message to differentiate between cancellation credit and legacy credit for clarity.
Comment on lines
+13
to
+14
| Task<CustomerBalanceTransaction> CustomerBalanceTransactionCreate(string customerId, | ||
| CustomerBalanceTransactionCreateOptions options); |
There was a problem hiding this comment.
style: Consider adding XML documentation for this new method to improve code clarity and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13717
📔 Objective
This PR fixes 2 issues:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changesGreptile Summary
This pull request addresses issues with legacy credit rebates for migrated MSPs in the billing system. Key changes include:
ApplyCreditAsyncinProviderMigrator.csto correctly handle legacy credit rebatesCustomerBalanceTransactionCreatemethod toIStripeAdapterinterfaceCustomerBalanceTransactionCreateinStripeAdapterclass using Stripe's APICustomerBalanceTransactionServiceinStripeAdapterfor improved balance managementThese changes enhance the accuracy and transparency of credit applications for migrated MSP organizations, fixing issues with legacy plan detection and credit allocation.