[PM-10338] Update the Organization 'Leave' endpoint to log EventType.OrganizationUser_Left #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10338
📔 Objective
When a user leaves an organization log the event
EventType.OrganizationUser_Left
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changesGreptile Summary
This pull request updates the 'Leave' endpoint in the OrganizationsController to log the event when a user leaves an organization, implementing the new UserLeaveAsync method across multiple components.
UserLeaveAsync
method toIRemoveOrganizationUserCommand
interface in/src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/Interfaces/IRemoveOrganizationUserCommand.cs
UserLeaveAsync
inRemoveOrganizationUserCommand
class, loggingEventType.OrganizationUser_Left
in/src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/RemoveOrganizationUserCommand.cs
OrganizationsController
to useUserLeaveAsync
instead ofRemoveUserAsync
in/src/Api/AdminConsole/Controllers/OrganizationsController.cs
UserLeave
functionality in/test/Core.Test/AdminConsole/OrganizationFeatures/OrganizationUsers/RemoveOrganizationUserCommandTests.cs
/test/Api.Test/AdminConsole/Controllers/OrganizationsControllerTests.cs
to reflect the newUserLeaveAsync
method